FIX: Dark mode and updated SCSS compiler compatibility #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
approved these changes
Feb 2, 2021
Member
davidtaylorhq
left a comment
davidtaylorhq
left a comment
There was a problem hiding this comment.
Does the import change break this theme for older versions of Discourse? If so we might want to add a .discourse-compatibility file?
Contributor
Author
|
No, I don't think so, in previous versions of Discourse, theme variables are injected by core for all theme fields. So the imports were not doing anything useful. And for the dark-mode color changes, the previous entry in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@import "theme_variables"is no longer supported in core since discourse/discourse@e8b8272 (and is not necessary, core already injects those variables)