Allow streaming ingest for FlightClient::execute_ingest #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 13, 2024
| command: CommandStatementIngest, | ||
| batches: Vec<RecordBatch>, | ||
| ) -> Result<i64, ArrowError> { | ||
| stream: S, |
Author
There was a problem hiding this comment.
this is the key change -- to change the API to take a stream of record batches rather than a Vec of batches. This change I think allows the whole API to be streaming
alamb
commented
Aug 13, 2024
| #[derive(Clone)] | ||
| pub struct FlightSqlServiceImpl { | ||
| transactions: Arc<Mutex<HashMap<String, ()>>>, | ||
| ingested_batches: Arc<Mutex<Vec<RecordBatch>>>, |
Author
There was a problem hiding this comment.
I also propose extending the test slightly to ensure that the batches came through unchanged (in addition to the row count being sent back correctly)
Owner
|
@alamb, this is great, I figured there was a way to make the API streaming but wasn't sure of the best way. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed modifications to apache#6201