Fix unhashed secret to work with request body authentication. #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the client to send credentials in the request body when the application has an unhashed secret. Signed-off-by: Alex Manning <[email protected]>
Signed-off-by: Alex Manning <[email protected]>
n2ygk
approved these changes
Oct 7, 2023
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 32 32
Lines 2073 2073
=======================================
Hits 2020 2020
Misses 53 53
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
#1311 allowed the use of unhashed client secrets, but if a secret is unhashed it does not work if the client includes it's client_id and client_secret in the request body, instead of using basic auth- only hashed secrets work in that case.
This PR allows hashed or unhashed secrets in _authenticate_request_body too, and adds a test for this case.
I think this is small enough that it can really just be considered part of 1311 in terms of documentation and changelog- but if I'm wrong please let me know and I can come back.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS