This repository was archived by the owner on Feb 19, 2020. It is now read-only.
SimpleLexicon tidy up.
#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Your first commit adds the executable bit to the file - could you fix that? |
Owner
|
lg otherwise |
Owner
|
(and thanks!) |
jovilius
force-pushed
the
master
branch
2 times, most recently
from
83e9e85 to
1ba5a2b
Compare
added 7 commits
April 21, 2015 01:26
Contributor
Author
|
@reactormonk, @dlwh I've removed the executable bit in the first commit. What's your procedure to merge the PR into master? Do I need to have write access on Thanks, G. |
Collaborator
|
Looks good according to @dlwh. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dlwh, I'm very interested in your project and I would like to contribute to it. In this PR you can see some little improvements in term of style and syntax. Does it make sense for you?
Thanks, G.