Expose swallowed exception

[briantopping]

Expose swallowed exception that was hiding an java.io.InvalidClassException during deserialization.

Would like to follow on with moving output to Java logging or slf4j. It would be a great way for me to get familiar with the code and give back something at the same time. The code that I patched here has an "expected" exception that fires off a call to classPathLoad, but in this case, only an IOException was expected, so it wasn't caught or logged, resulting in another error that could have been anything. This is one of the challenges with using runtime exceptions, but it's pretty easy to just put in a top-level exception handler to dump the trace as well.

[dlwh]

could you inherit from SerializableLogging (or something) and just use logger.error ?

[dlwh]

could you also try adding ", true" to the readObject call on line 44, and see if that fixes the problem?

[briantopping]

Modifying the readObject call did not help: Couldn't deserialize model due to exception, epic.parser.models.ParserTrainer$$anonfun$2; local class incompatible: stream classdesc serialVersionUID = 0, local class serialVersionUID = 5531977503861241212. Trying classPathLoad...

As for the logging, I should have mentioned a reason to use a formal logger is for message redirection when the code is used in a larger container. I will look at SerializableLogging, thanks for the pointer!

[briantopping]

Some progress: When I modify https://github.com/briantopping/epic/blob/pr32/src/main/scala/epic/models/package.scala#L21-21 to breeze.util.nonstupidObjectInputStream(new GZIPInputStream(zip.getInputStream(e)), true).readObject().asInstanceOf[T], I get the output at https://gist.github.com/briantopping/d0578d16a17a01796ef3. It eventually still gives up deserializing the graph, it just does so after more effort.

[dlwh]

blah, ok.

On Thu, May 14, 2015 at 2:45 AM, Brian Topping [email protected]
wrote:

Some progress: When I modify
https://github.com/briantopping/epic/blob/pr32/src/main/scala/epic/models/package.scala#L21-21
to breeze.util.nonstupidObjectInputStream(new
GZIPInputStream(zip.getInputStream(e)), true).readObject().asInstanceOf[T],
I get the output at
https://gist.github.com/briantopping/d0578d16a17a01796ef3. It eventually
still gives up deserializing the graph, it just does so after more effort.

—
Reply to this email directly or view it on GitHub
#32 (comment).

[ktham]

Why Exception and not Throwable?

[briantopping]

I didn't spend a lot of time on it, probably could be improved!