Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

Conversation

@adampauls
Copy link
Collaborator

No description provided.


trait ArgmaxInferencer[T, Y, W] {

def argmax(weights : Weights[W], instance : T) : (Y, FeatureVector[W], Double)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic has a whole parallel infrastructure for this, but i'm gonna let it go through for now since we need it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be private then. I'd advocate against pushing APIs that one doesn't want (or are redundant). Some kinds of technical debt is ok if eventually dealt with. Pushing breaking API changes to handle technical debt is not optimal.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey malcolm, you're missing some context. we need this internally soon and i doubt it will last all that long in this state.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so this is some behind-the-scenes leaking out into the public space? ;-)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more or less :)

Hopefully it won't get out that our obscure little outfit is using structured max margin methods!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that certainly sounds like some really interesting work you are all doing! It also sounds like I should buy you a cup of coffee and ask you many questions, most of which you'll just have to smile, nod, and say "well you didn't sign an NDA so..." =D

resolvers += Resolver.url("artifactory", url("http://scalasbt.artifactoryonline.com/scalasbt/sbt-plugin-releases"))(Resolver.ivyStylePatterns)

addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.13.0")
addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "4.0.0")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlwh are you okay with this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adampauls I'd put any personal IDE config into ~/.sbt/0.13/plugins/plugins.sbt

Copy link
Collaborator Author

@adampauls adampauls May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Didn't know you could do that.

data.count { instance =>
loopWhile(numInnerOptimizationLoops) {
updater.update(instance, w, n, iteration)
} > 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, don't like this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

iter >= maxNumIters || (objectiveConverged(weights, data, iter) && numNewConstraints == 0)
}

private def close(a : Double, b : Double) = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use your numutils function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dlwh
Copy link
Owner

dlwh commented May 26, 2016

ok well, there's lots of stuff that should be cleaned up/unified with epic/breeze, but let's not block your progress

@adampauls
Copy link
Collaborator Author

Indeed. I'm happy to do some unifying (with your help), but I'd like to get this in so it exists for other use.

@dlwh dlwh merged commit d2093b4 into master May 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants