-
Notifications
You must be signed in to change notification settings - Fork 81
Conversation
|
|
||
| trait ArgmaxInferencer[T, Y, W] { | ||
|
|
||
| def argmax(weights : Weights[W], instance : T) : (Y, FeatureVector[W], Double) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epic has a whole parallel infrastructure for this, but i'm gonna let it go through for now since we need it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be private then. I'd advocate against pushing APIs that one doesn't want (or are redundant). Some kinds of technical debt is ok if eventually dealt with. Pushing breaking API changes to handle technical debt is not optimal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey malcolm, you're missing some context. we need this internally soon and i doubt it will last all that long in this state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so this is some behind-the-scenes leaking out into the public space? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more or less :)
Hopefully it won't get out that our obscure little outfit is using structured max margin methods!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that certainly sounds like some really interesting work you are all doing! It also sounds like I should buy you a cup of coffee and ask you many questions, most of which you'll just have to smile, nod, and say "well you didn't sign an NDA so..." =D
project/plugins.sbt
Outdated
| resolvers += Resolver.url("artifactory", url("http://scalasbt.artifactoryonline.com/scalasbt/sbt-plugin-releases"))(Resolver.ivyStylePatterns) | ||
|
|
||
| addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.13.0") | ||
| addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "4.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlwh are you okay with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adampauls I'd put any personal IDE config into ~/.sbt/0.13/plugins/plugins.sbt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Didn't know you could do that.
| data.count { instance => | ||
| loopWhile(numInnerOptimizationLoops) { | ||
| updater.update(instance, w, n, iteration) | ||
| } > 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, don't like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about now?
| iter >= maxNumIters || (objectiveConverged(weights, data, iter) && numNewConstraints == 0) | ||
| } | ||
|
|
||
| private def close(a : Double, b : Double) = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use your numutils function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
ok well, there's lots of stuff that should be cleaned up/unified with epic/breeze, but let's not block your progress |
|
Indeed. I'm happy to do some unifying (with your help), but I'd like to get this in so it exists for other use. |
No description provided.