Skip to content

WIP: HTML API: Expose self-closing flag in Tag Processor #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmsnell wants to merge 8 commits into from
Closed

WIP: HTML API: Expose self-closing flag in Tag Processor #3

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
84e35ef
WIP: HTML API: Expose self-closing flag in Tag Processor
dmsnell Mar 2, 2023
84e25cf
Expand documentation
dmsnell Mar 2, 2023
c18a81a
Appease the linting gods
dmsnell Mar 2, 2023
af8d49d
Add extra tests for syntax peculiarities.
dmsnell Mar 2, 2023
72e5de0
Appease the linting gods
dmsnell Mar 2, 2023
095a110
Appease the linting gods
dmsnell Mar 2, 2023
9b3f90d
Appease the linting gods
dmsnell Mar 2, 2023
e945f16
Add Trac ticket reference to tests
dmsnell Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Appease the linting gods
  • Loading branch information
@dmsnell
dmsnell committed Mar 7, 2023
commit 9b3f90d7bdf26c0c61ab63888f122b2bc196a83c
6 changes: 3 additions & 3 deletions tests/phpunit/tests/html-api/wpHtmlTagProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@ public function test_has_self_closing_flag_matches_input_html( $html, $flag_is_s
public function data_has_self_closing_flag() {
return array(
// These should not have a self-closer, and will leave an element un-closed if it's assumed they are self-closing.
'Self-closing flag on non-void HTML element' => array( '<div />', true ),
'Self-closing flag on non-void HTML element' => array( '<div />', true ),
'No self-closing flag on non-void HTML element' => array( '<div>', false ),
// These should not have a self-closer, but are benign when used because the elements are void.
'Self-closing flag on void HTML element' => array( '<img />', true ),
'Self-closing flag on void HTML element' => array( '<img />', true ),
'No self-closing flag on void HTML element' => array( '<img>', false ),
// These should not have a self-closer, but as part of a tag closer they are entirely ignored.
'Self-closing flag on tag closer' => array( '</textarea />', true ),
'Self-closing flag on tag closer' => array( '</textarea />', true ),
'No self-closing flag on tag closer' => array( '</textarea>', false ),
// These can and should have self-closers, and will leave an element un-closed if it's assumed they aren't self-closing.
'Self-closing flag on a foreign element' => array( '<circle />', true ),
Expand Down