Skip to content

fix(clickCount): dispatch appropriate amount of clicks with clickCount #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2022
Merged

fix(clickCount): dispatch appropriate amount of clicks with clickCount #212

merged 1 commit into from
Jan 2, 2022

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Dec 27, 2021

No description provided.

@Andarist Andarist mentioned this pull request Dec 27, 2021
Open
dmtrKovalenko
dmtrKovalenko reviewed Jan 2, 2022
View reviewed changes
Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn’t it work before?

@Andarist
Copy link
Contributor Author

Andarist commented Jan 2, 2022

Yes, the added test fails on the develop branch. It's not always obvious what exact effects any given CDP command might have - how much is automated and handled by them and how much we need to do manually~. This is the latter case, it turned out that when multi-clicking we need to dispatch several click commands to match the "real" behavior.

@dmtrKovalenko dmtrKovalenko merged commit 8994a09 into develop Jan 2, 2022
dmtrKovalenko pushed a commit that referenced this pull request Feb 11, 2022
@Andarist @dmtrKovalenko
fix(clickCount): dispatch appropriate amount of clicks with clickCount (
af1861a 
#212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmtrKovalenko dmtrKovalenko dmtrKovalenko left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Andarist @dmtrKovalenko