Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 15, 2020

vendor: github.com/spf13/cobra v1.1.1

full diff: spf13/cobra@v1.0.0...v1.1.1

Notable changes:

  • Extend Go completions and revamp zsh comp
  • Add completion for help command
  • Complete subcommands when TraverseChildren is set
  • Fix stderr printing functions
  • fix: fish output redirection
  • fix manpage building with new go-md2man

relates to / addresses docker/docker-ce-packaging#502

@codecov-io
Copy link

Codecov Report

Merging #2794 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2794   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files         297      297           
  Lines       18634    18634           
=======================================
  Hits        10649    10649           
  Misses       7126     7126           
  Partials      859      859           

3 similar comments
@codecov-commenter
Copy link

Codecov Report

Merging #2794 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2794   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files         297      297           
  Lines       18634    18634           
=======================================
  Hits        10649    10649           
  Misses       7126     7126           
  Partials      859      859           

@codecov-io
Copy link

Codecov Report

Merging #2794 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2794   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files         297      297           
  Lines       18634    18634           
=======================================
  Hits        10649    10649           
  Misses       7126     7126           
  Partials      859      859           

@codecov-commenter
Copy link

Codecov Report

Merging #2794 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2794   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files         297      297           
  Lines       18634    18634           
=======================================
  Hits        10649    10649           
  Misses       7126     7126           
  Partials      859      859           

@thaJeztah
Copy link
Member Author

We may want to wait for the discussion on spf13/cobra#1259 to settle, or skip the yaml version bump.

I was doing this vendor in preparation of spf13/cobra#1255 to be merged upstream. Let me move this back to draft in the meantime

@thaJeztah thaJeztah marked this pull request as draft October 17, 2020 08:39
@thaJeztah thaJeztah changed the title vendor: github.com/spf13/cobra v1.1.0, gopkg.in/yaml.v2 v2.3.0 [on hold, pending upstream changes] vendor: github.com/spf13/cobra v1.1.0, gopkg.in/yaml.v2 v2.3.0 Oct 17, 2020
full diff: spf13/cobra@v1.0.0...v1.1.1

Notable changes:

- Extend Go completions and revamp zsh comp
- Add completion for help command
- Complete subcommands when TraverseChildren is set
- Fix stderr printing functions
- fix: fish output redirection
- fix manpage building with new go-md2man

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title [on hold, pending upstream changes] vendor: github.com/spf13/cobra v1.1.0, gopkg.in/yaml.v2 v2.3.0 vendor: github.com/spf13/cobra v1.1.1 Oct 20, 2020
@thaJeztah thaJeztah marked this pull request as ready for review October 20, 2020 10:42
@thaJeztah
Copy link
Member Author

Updated to v1.1.1 and removed the YAML bump

@thaJeztah thaJeztah added this to the 20.10.0 milestone Oct 20, 2020
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 16127e2 into docker:master Oct 20, 2020
@thaJeztah thaJeztah deleted the bump_cobra branch October 20, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants