moved dns to client.start #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nic Grayson <[email protected]>
|
Thanks. Not sure about those warnings being removed though - we don't want to diverge from docker-py without pushing changes upstream. I think we should pass an explicit API version when instantiating the docker-py client, and not support earlier daemons which expect |
Conflicts: fig/service.py
|
Obsoleted by 140ced6, I believe. |
xulike666
pushed a commit
to xulike666/compose
that referenced
this pull request
Jan 19, 2017
set default shim if shim is nil for backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so you can define a container like this:
test:
image: foo
dns: ip.ad.re.ss
Note: This removes the warnings from docker/docker-py#245 regarding dns being deprecated in docker api 1.12