Use true_name for remove operation

Signed-off-by: Joffrey F <[email protected]>

compose/network.py

@@ -95,14 +95,11 @@ def ensure(self):
 
     def remove(self):
         if self.external:
-            log.info("Network %s is external, skipping", self.full_name)
+            log.info("Network %s is external, skipping", self.true_name)
             return
 
         log.info("Removing network {}".format(self.true_name))
-        try:
-            self.client.remove_network(self.full_name)
-        except NotFound:
-            self.client.remove_network(self.legacy_full_name)
+        self.client.remove_network(self.true_name)
 
     def inspect(self, legacy=False):
         if legacy:

compose/volume.py

@@ -38,13 +38,10 @@ def create(self):
 
     def remove(self):
         if self.external:
-            log.info("Volume %s is external, skipping", self.full_name)
+            log.info("Volume %s is external, skipping", self.true_name)
             return
-        log.info("Removing volume %s", self.full_name)
-        try:
-            return self.client.remove_volume(self.full_name)
-        except NotFound:
-            self.client.remove_volume(self.legacy_full_name)
+        log.info("Removing volume %s", self.true_name)
+        return self.client.remove_volume(self.true_name)
 
     def inspect(self, legacy=None):
         if legacy:

tests/unit/network_test.py

@@ -84,6 +84,7 @@ def test_check_remote_network_config_whitelist(self):
             {'Driver': 'overlay', 'Options': remote_options}, net
         )
 
+    @mock.patch('compose.network.Network.true_name', lambda n: n.full_name)
     def test_check_remote_network_config_driver_mismatch(self):
         net = Network(None, 'compose_test', 'net1', 'overlay')
         with pytest.raises(NetworkConfigChangedError) as e:
@@ -93,6 +94,7 @@ def test_check_remote_network_config_driver_mismatch(self):
 
         assert 'driver has changed' in str(e.value)
 
+    @mock.patch('compose.network.Network.true_name', lambda n: n.full_name)
     def test_check_remote_network_config_options_mismatch(self):
         net = Network(None, 'compose_test', 'net1', 'overlay')
         with pytest.raises(NetworkConfigChangedError) as e:
@@ -146,6 +148,7 @@ def test_check_remote_network_config_null_remote_ipam_options(self):
             net
         )
 
+    @mock.patch('compose.network.Network.true_name', lambda n: n.full_name)
     def test_check_remote_network_labels_mismatch(self):
         net = Network(None, 'compose_test', 'net1', 'overlay', labels={
             'com.project.touhou.character': 'sakuya.izayoi'

tests/unit/project_test.py

@@ -60,6 +60,7 @@ def test_from_config_v1(self):
         assert project.get_service('db').options['image'] == 'busybox:latest'
         assert not project.networks.use_networking
 
+    @mock.patch('compose.network.Network.true_name', lambda n: n.full_name)
     def test_from_config_v2(self):
         config = Config(
             version=V2_0,
@@ -217,6 +218,7 @@ def test_use_volumes_from_service_no_container(self):
         )
         assert project.get_service('test')._get_volumes_from() == [container_name + ":rw"]
 
+    @mock.patch('compose.network.Network.true_name', lambda n: n.full_name)
     def test_use_volumes_from_service_container(self):
         container_ids = ['aabbccddee', '12345']