Skip to content

Conversation

allencloud
Copy link
Contributor

Signed-off-by: allencloud [email protected]

This PR is related to PR #1605.

This is my fault to ignore test the following status code at the test case test_remove_main_node . The original thought of this PR is from moby/moby#32122.

What I did:

  1. update node remove test status code from 500 to >= 400

ping @shin- @stevvooe

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not a maintainer here)

@stevvooe
Copy link

LGTM (not a maintainer)

@shin- shin- merged commit dc2b24d into docker:master May 22, 2017
@allencloud allencloud deleted the update-swarm-remove-test-status-code-from-500-to-400 branch May 23, 2017 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants