allow ipv6 :: notation in split_port (using re) #1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about commit signatures, will fix that asap. |
In the case of a defined format with specific parts, a regular expression with named capturing bits make reasoning about the parts simpler than imlementing a parser from scratch. Signed-off-by: kaiyou <[email protected]>
The test was copied from greybyte@ccec87c Signed-off-by: kaiyou <[email protected]>
shin-
approved these changes
Jun 16, 2017
| if not external: | ||
| external = [None] * len(internal) | ||
| elif len(internal) != len(external): | ||
| raise ValueError('Port ranges don\'t match in length') |
There was a problem hiding this comment.
nitpick: It feels like there should be a way to have this raise statement only once, but it's not immediately obvious to me what is the best way to get there.
This was referenced Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a defined format with specific parts, a regular
expression with named capturing bits makes reasoning about the
parts simpler than imlementing a parser from scratch.
This is strongly related to #1404 and simply provides a suggested implementation using regular expressions.