Return API response on service update #2272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response contains a
Warningskey that should be returned so it can be handled by the caller.See the 200 Response documentation here: https://docs.docker.com/engine/api/v1.39/#operation/ServiceUpdate
Currently the only return value from this method is
True. It can never returnFalse(it will raise instead).With this change checks like this on the return value will still work:
But it would break backwards compatability if used like this:
As previously stated both these checks does not make sense as the only possible return value is
True.