This repository was archived by the owner on May 22, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Add scope support to access tokens #185
Open
thinkst-marco
wants to merge
1
commit into
docker:main
Choose a base branch
from
thinkst-marco:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,12 @@ var ( | |
| s := fmt.Sprintf("%v", t.IsActive) | ||
| return s, len(s) | ||
| }}, | ||
| {"SCOPE", func(t hub.Token) (string, int) { | ||
| if len(t.Scopes) == 0 { | ||
| return "", 0 | ||
| } | ||
| return t.Scopes[0][5:], len(t.Scopes[0]) - 5 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess |
||
| }}, | ||
| } | ||
| ) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -46,11 +46,19 @@ type Token struct { | |||||||||
| IsActive bool | ||||||||||
| Token string | ||||||||||
| Description string | ||||||||||
| Scopes []string | ||||||||||
| } | ||||||||||
|
|
||||||||||
| // CreateToken creates a Personal Access Token and returns the token field only once | ||||||||||
| func (c *Client) CreateToken(description string) (*Token, error) { | ||||||||||
| data, err := json.Marshal(hubTokenRequest{Description: description}) | ||||||||||
| func (c *Client) CreateToken(description string, scope string) (*Token, error) { | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit:
Suggested change
|
||||||||||
| tokenRequest := hubTokenRequest{Description: description} | ||||||||||
| if len(scope) > 0 { | ||||||||||
| scopes := []string{scope} | ||||||||||
| scopes[0] = "repo:" + scope | ||||||||||
| tokenRequest.Scopes = scopes | ||||||||||
|
Comment on lines
+56
to
+58
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Am I missing something? Why can’t it be
Suggested change
? |
||||||||||
| } | ||||||||||
|
|
||||||||||
| data, err := json.Marshal(tokenRequest) | ||||||||||
| if err != nil { | ||||||||||
| return nil, err | ||||||||||
| } | ||||||||||
|
|
@@ -190,8 +198,9 @@ func (c *Client) getTokensPage(url string) ([]Token, int, string, error) { | |||||||||
| } | ||||||||||
|
|
||||||||||
| type hubTokenRequest struct { | ||||||||||
| Description string `json:"token_label,omitempty"` | ||||||||||
| IsActive bool `json:"is_active"` | ||||||||||
| Description string `json:"token_label,omitempty"` | ||||||||||
| Scopes []string `json:"scopes,omitempty"` | ||||||||||
| IsActive bool `json:"is_active"` | ||||||||||
| } | ||||||||||
|
|
||||||||||
| type hubTokenResponse struct { | ||||||||||
|
|
@@ -212,6 +221,7 @@ type hubTokenResult struct { | |||||||||
| IsActive bool `json:"is_active"` | ||||||||||
| Token string `json:"token"` | ||||||||||
| TokenLabel string `json:"token_label"` | ||||||||||
| Scopes []string `json:"scopes"` | ||||||||||
| } | ||||||||||
|
|
||||||||||
| func convertToken(response hubTokenResult) (Token, error) { | ||||||||||
|
|
@@ -230,5 +240,6 @@ func convertToken(response hubTokenResult) (Token, error) { | |||||||||
| IsActive: response.IsActive, | ||||||||||
| Token: response.Token, | ||||||||||
| Description: response.TokenLabel, | ||||||||||
| Scopes: response.Scopes, | ||||||||||
| }, nil | ||||||||||
| } | ||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would extract these into a
[]stringand use it withstrings.Jointo build the description for the flag l.78