Fixes #68: failed healthchecks due to file path #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Happy New Year! |
Member
|
Happy new year! This is due to a regression introduced in moby/moby#35661; see moby/moby#35843, and moby/moby#35845 |
thaJeztah
approved these changes
Jan 1, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
even though this was a regression; doesn't hurt to use an absolute path here 👍
Closed
|
@thaJeztah Thanks for the references. |
|
Thanks @BretFisher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed node didn't like relative paths. Tried several things like
execmode for the CMD, and also tried./healthcheck.js, but it only seems to work as a healthcheck if full path is used.Weird that
docker exec <containerid> node healthcheck.jsworked manually, so docker must be running the healthcheck slightly differently.¯\_(ツ)_/¯