Skip to content

Use multi-arch node base image #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManoMarks merged 5 commits into from
Jan 2, 2019
Merged

Use multi-arch node base image #105

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ffb5d1
Use multi-arch node:8-alpine as base image
RandomByte Feb 11, 2018
3d28a24
Remove Dockerfile.arm
RandomByte Feb 11, 2018
f180e56
Explain custom build and re-add ARM image reference
RandomByte Feb 11, 2018
f891f2e
Readme: Omit '-f Dockerfile' where not needed
RandomByte Feb 12, 2018
7acef58
Readme: Differentiate between ARM and armhf
RandomByte Feb 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Latest version of node tested on.
FROM node:8.2.1-alpine AS dist
FROM node:8-alpine AS dist

WORKDIR /app

Expand All @@ -15,7 +15,7 @@ ADD . /app
RUN npm run dist


FROM node:8.2.1-alpine
FROM node:8-alpine

WORKDIR /app
ADD ./cfg/* /app/cfg/
Expand Down
24 changes: 0 additions & 24 deletions Dockerfile.arm
View file
Open in desktop

This file was deleted.

28 changes: 26 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ $ docker service create \
dockersamples/visualizer
```

## Supported architectures

The main `dockersamples/visualizer` image supports **linux/amd64**.

**For ARM**, there is a pre-built image available. See [Running on ARM](#running-on-arm).
Copy link
Contributor

@alexellis alexellis Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more specific about "arm" - this works for armhf only, it won't work for 64-bit ARM such as that found on Packet's or Scaleway's servers or the Pine64 etc.

Copy link
Contributor Author

@RandomByte RandomByte Feb 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Done 👍


**For Windows**, there is a separate `Dockerfile.windows` and image. See [Running on Windows](#running-on-windows).

**Missing your architecture?** See [Building a custom image](#building-a-custom-image).

## Running on ARM
Copy link
Contributor

@alexellis alexellis Feb 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not remove this section. Someone will still have to build and maintain an image on the Docker Hub.


[@alexellisuk](https://twitter.com/alexellisuk) has pushed an image to the Docker Hub as `alexellis2/visualizer-arm:latest` it will run the code on an ARMv6 or ARMv7 device such as the Raspberry Pi.
Expand All @@ -61,7 +71,7 @@ $ docker service create \
If you would like to build the image from source run the following command:

```
$ docker build -f Dockerfile.arm -t visualizer-arm:latest .
$ docker build -f Dockerfile -t visualizer-arm:latest .
Copy link
Contributor

@StefanScherer StefanScherer Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can omit -f Dockerfile here.

```

[View on Docker Hub](https://hub.docker.com/r/alexellis2/visualizer-arm/tags/)
Expand Down Expand Up @@ -103,7 +113,21 @@ $ip=(Get-NetIPAddress -AddressFamily IPv4 `
docker run -d -p 8080:8080 -e DOCKER_HOST=${ip}:2376 -e DOCKER_TLS_VERIFY=1 -v "$env:USERPROFILE\.docker:C:\Users\ContainerAdministrator\.docker" --name=visualizer stefanscherer/visualizer-windows
```

TODO:
## Building a custom image
*When building for Windows, see [Running on Windows](#running-on-windows)*.

To build an up-to-date image for any architecture supported by [node:8-alpine](https://hub.docker.com/_/node/) (currently `amd64`, `arm32v6`, `arm32v7`, `arm64v8`, `i386`, `ppc64le` and `s390x`), execute the following command on a device of your target architecture:
```
$ docker build -f Dockerfile -t visualizer-custom:latest .
Copy link
Contributor

@StefanScherer StefanScherer Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can omit -f Dockerfile here.

```

Afterwards you can start visualizer by using any of the commands stated [above](#docker-swarm-visualizer). Just replace `dockersamples/visualizer` with `visualizer-custom`. For example:
```
$ docker run -it -d -p 8080:8080 -v /var/run/docker.sock:/var/run/docker.sock visualizer-custom
```


## TODO:
* Take out or fix how dist works
* Comment much more extensively
* Create tests and make them work better
Expand Down