[ARM64] update deprecated aarch64 architecture to current arm64v8 and catch up with main Dockerfile #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4v8; catch up with changes made to primary Dockerfile
ikluft
changed the title
Author
|
I resubmitted this as Pull Request #121 in its own branch "arm64v8-update". That also catches up activity on master since then, and bumps the version of node from 8.11 to 8.12 to pick up security patches. (That version bump should be done on the other Dockerfiles too, but is outside the scope of this PR.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting changes I made to get the Visualizer to work on a Raspberry Pi 3 cluster. Docker's docs say the aarch64 architecture is deprecated in favor of arm64v8. Also, the old Dockerfile.aarch64 hasn't kept up with changes to the primary Dockerfile, which when applied reduced the image size from 341MB to 157MB.
The changes in this PR are: 1) rename Dockerfile.aarch64 to Dockerfile.arm64v8, 2) update Dockerfile.arm64v8 with changes that have been made to Dockerfile, 3) update the README.md to describe this option for ARM64.