master #23
Merged
master #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # src/data-provider.js # src/vis-physical/index.js
…visualizer is installed)
Contributor
Author
|
all .sh files should be removed |
| @@ -0,0 +1,124 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
@DovAmir last time we determined this file wasn't required. Can we leave it out?
Contributor
Author
There was a problem hiding this comment.
yes sorry about that, i thought it was in .gitignore
the .idea directory and the *.sh files should not be there
| for(let i=0;i<objects.length;i++){ | ||
| let object = objects[i]; | ||
| if(object.Status.State=="running" && object.DesiredState=="running") { | ||
| if( object.DesiredState=="running") { //object.Status.State=="running" && |
Contributor
There was a problem hiding this comment.
Did you mean to comment out object.Status.State @DovAmir?
Contributor
Author
There was a problem hiding this comment.
Yes, If a containers DesiredState is running, but its actual state is failed, I want it to appear in the UI with a red failed state,
see the updated nodes.png to see why I want to show non running states.
ManoMarks
approved these changes
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mode ui improvments:
show container status (running/faild)
show many containers in a node clearly
click container to see all container data (currently works only in master )