Center node cluster div and add search feature to containers #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good |
Contributor
Author
|
i also have another functionality worked out that we are using internally. perhaps that should be rolled as a separate PR? |
Contributor
|
@aloyr As a fun/cool thing to do, make the search bar show when you click the "docker logo". |
Contributor
Author
|
ok, @pahakalle, I've polished the the search filter animation a bit and implemented the click event on the logo. |
Contributor
Author
|
@pahakalle are you able to merge this PR? or only @ManoMarks can do this? |
aloyr
changed the title
Contributor
|
Only @ManoMarks can merge (not sure if someone else can also), i'm not part of the dev team. |
Contributor
Author
|
ok, thanks! |
BretFisher
approved these changes
Oct 11, 2017
Collaborator
BretFisher
left a comment
BretFisher
left a comment
There was a problem hiding this comment.
LGTM, looks/works great from aloyr's branch
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change that centers the node cluster div on the screen.