Skip to content

Conversation

@aloyr
Copy link
Contributor

@aloyr aloyr commented Aug 18, 2017

This is a simple change that centers the node cluster div on the screen.

image

@bariman
Copy link

bariman commented Aug 18, 2017

looks good

@aloyr
Copy link
Contributor Author

aloyr commented Sep 8, 2017

i also have another functionality worked out that we are using internally. perhaps that should be rolled as a separate PR?
test filter

@ThatLurker
Copy link
Contributor

@aloyr As a fun/cool thing to do, make the search bar show when you click the "docker logo".

@aloyr
Copy link
Contributor Author

aloyr commented Sep 19, 2017

ok, @pahakalle, I've polished the the search filter animation a bit and implemented the click event on the logo.

search filter

@aloyr
Copy link
Contributor Author

aloyr commented Sep 19, 2017

@pahakalle are you able to merge this PR? or only @ManoMarks can do this?

@aloyr aloyr changed the title Center node cluster div Center node cluster div and add search feature to containers Sep 19, 2017
@ThatLurker
Copy link
Contributor

Only @ManoMarks can merge (not sure if someone else can also), i'm not part of the dev team.

@aloyr
Copy link
Contributor Author

aloyr commented Sep 19, 2017

ok, thanks!

Copy link
Collaborator

@BretFisher BretFisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks/works great from aloyr's branch

@BretFisher
Copy link
Collaborator

LGTM

@ManoMarks ManoMarks merged commit 14a8fb3 into dockersamples:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants