Use Windows named pipe #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested Visualizer with Windows Server Insider 16278 and Docker 17.09.0-ce-rc2 which allows me to map the Windows named pipe
\\.\pipe\docker_engineinto a Windows container.This is the equivalent to the Unix socket
/var/run/docker.sock.This PR adds the usage of the Windows named pipe if running on Windows.
My
Dockerfile.insiderto build the example imagestefanscherer/visualizer-windows:insiderthat is also available on Docker Hub:After building the image and running it
The Visualizer is running and can monitor the services in the swarm. Only from time to time there are some connection problems to that named pipe. Here is a screenshot with some debug console.logs that shows that the most of the requests are successful.
This problem may be related to microsoft/go-winio#67 which we found running Portainer with a Windows named pipe in a Windows container. So this is no problem of the Visualizer itself.
/cc @friism