Skip to content

Sync filter options with URL parameter #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManoMarks merged 6 commits into from
Nov 29, 2017
Merged

Sync filter options with URL parameter #93

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c96c631
url_param: Make request.js ignore query params
aloyr Oct 27, 2017
9a3ed1e
url_param: Implement param processing methods
aloyr Oct 27, 2017
bc59b70
url_param: Fire param detection onload
aloyr Oct 27, 2017
9d47d54
url_param: Sync filter options and URL params
aloyr Oct 27, 2017
0346bdb
url_param: Tweak typing timer
aloyr Oct 27, 2017
e316de3
url_param: Add timeout before calling filterOnLoad
aloyr Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
url_param: Sync filter options and URL params 
The idea here is to be able to directly access filtered container list
via a URL parameter called "filter".
  • Loading branch information
@aloyr
aloyr committed Oct 27, 2017
commit 9d47d548bbd8ef0743101cadb5759c07ad4c966f
4 changes: 2 additions & 2 deletions src/utils/filter-containers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function filterHistory() {
}

function filterMap(element) {
let component = element.split('&');
let component = element.split('=');
this[component[0]] = component[1];
return this;
}
Expand Down Expand Up @@ -71,7 +71,7 @@ export function filterOnLoad() {
.map(filterMap, {})[0];

if (searchObj.filter) {
filterInput.value = search;
filterInput.value = searchObj.filter;
console.log('about to call filterContainers');
console.log(typeof filterContainers);
filterContainers();
Expand Down