Skip to content

Conversation

@LayZeeDK
Copy link
Contributor

Timestamps with minute count lower than 10 should be zeropadded such that 19:6 becomes 19:06.
image

Timestamps with minute count lower than 10 should be zeropadded such that `19:6` becomes `19:06`.
@ManoMarks
Copy link
Contributor

I try to use this and I get this error in chrome dev tools:
Uncaught (in promise) TypeError: p.default.padStart is not a function
And it doesn't display anything once a service is deployed. Are you missing a dependency?

@LayZeeDK
Copy link
Contributor Author

My bad, @ManoMarks. Lodash needs to be updated to at least version 4.0.0 to include padStart. Currently it is at ^3.10.1 in package.json.

@ManoMarks
Copy link
Contributor

Updated Lodash to 4.17.4 in #97

@ManoMarks ManoMarks merged commit e1f13b8 into dockersamples:master Nov 30, 2017
@LayZeeDK
Copy link
Contributor Author

LayZeeDK commented Dec 1, 2017

I looked through the places where lodash is used in the repository. Here, I list some uses to look into.

_.findWhere

In src/vis-logical/index.js, _.findWhere is used multiple times. This method has been removed in lodash version 4.0.0 in favor of _.find.

_.findWhere is also used heavily in src/data-provider.js

_.bindAll

In src/utils/request.js, _,bindAll is used. In lodash version 4.0.0, a change was made to _.bindAll

Removed support for binding all methods by default from _.bindAll
--lodash Changelog v4.0.0

I am not sure whether the code is affected by this change.

LayZeeDK added a commit to LayZeeDK/docker-swarm-visualizer that referenced this pull request Oct 3, 2018
Reintroduces bugfix dockersamples#94 without upgrading Lodash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants