Skip to content

Detect DBAL's number type #11781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derrabus merged 1 commit into from
Jun 18, 2025
Merged

Detect DBAL's number type #11781

derrabus merged 1 commit into from
Jun 18, 2025

Conversation

@derrabus
Copy link
Member

@derrabus derrabus commented Jan 6, 2025

Leverages doctrine/dbal#6686.

@stof
Copy link
Member

stof commented Mar 24, 2025

How does BCMath\Number behaves regarding the change tracking in the ORM ? The discussion in DBAL says it should be compared with ==, and I don't think this is what the ORM does.

@derrabus
Copy link
Member Author

derrabus commented Apr 3, 2025

We kind of have the same problem here as we already do with DateTime objects. If you don't modify a property that stores a number, it's fine. But if you set that property to a new number object, it will be detected as changed even if the new number object is equal to the old one. But I don't think we need to solve this issue in this PR.

stof
stof reviewed Apr 3, 2025
View reviewed changes
tests/Tests/ORM/Mapping/TypedFieldMapperTest.php
* Data Provider for NamingStrategy#classToTableName
*
* @return array<
* @return Generator<
Copy link
Member

@stof stof Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generator requires 4 template types in its generic signature. I suggest using iterable as type instead.

Copy link
Member Author

@derrabus derrabus Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Generator<TKey, TValue> is widely understood by static analyzers.

@derrabus derrabus changed the base branch from 3.4.x to 3.5.x June 17, 2025 20:33
@derrabus derrabus requested a review from greg0ire June 17, 2025 20:35
@derrabus derrabus modified the milestone: 3.5.0 Jun 18, 2025
@derrabus derrabus merged commit 8c0994f into doctrine:3.5.x Jun 18, 2025
85 checks passed
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

Assignees

No one assigned

Labels

New Feature

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@derrabus @stof @greg0ire @SenseException