Skip to content

Conversation

@ameech
Copy link

@ameech ameech commented Jan 15, 2015

  • Added a namespace
  • Updated comments to a better format
  • Updated some private variables to protected so it can be extended

@ameech ameech changed the title Adds a namespace for PSR-4 Adds a namespace Jan 15, 2015
@ameech ameech changed the title Adds a namespace Minor cleanup of the class Jan 15, 2015
@ameech ameech changed the title Minor cleanup of the class Cleanup of the class Jan 15, 2015
@dolfelt
Copy link
Owner

dolfelt commented Feb 4, 2015

Let's ditch the [] for now since those are only available in PHP >=5.4. Let's increase requirements to >=5.4

Also, could you add the PSR-4 configuration to the composer file?

@shadowhand
Copy link

@dolfelt PHP 5.3 is EOL since August 2014, do we really need to continue to support it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a sub-namespace for every project/library:

namespace Wheniwork\Api;

@ameech
Copy link
Author

ameech commented Feb 4, 2015

Made a new PR. #3

@ameech ameech closed this Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants