-
-
Notifications
You must be signed in to change notification settings - Fork 655
Allow foreign keys on nonlocal tables #9989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d613452
Rename local variables pertaining to nonlocal tables.
nicktobey 6d70219
Allow creating foreign key on nonlocal table.
nicktobey ecd150a
nonlocal tables appear in show_tables
nicktobey 9ca908f
Prevent creating a table if it would clash with a nonlocal_tables rule.
nicktobey 34ca74a
Create TableResolver interface for allowing custom rules for resolvin…
nicktobey 139bced
Propagate a TableResolver into foreign key logic.
nicktobey 963e485
Support nonlocal tables in foreign key verification
nicktobey bd1b42e
Update nonlocal table bats tests.
nicktobey d9076bd
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…
nicktobey 3f583e6
Fix missing return when validating a FK pointing to a system table.
nicktobey 4b44b80
Rename added Database methods to clarify they return doltdb.Table, an…
nicktobey 0f9d804
Avoid dropping schema name when doing lookup.
nicktobey fd470d8
Refactor uses of TableResolver interface
nicktobey 9a163d5
Ensure uses of readNonlocalTables type
nicktobey 3ca970a
Add docstrings
nicktobey ba3fbd0
Add engine tests for nonlocal tables
nicktobey 0e2ddb4
Add case sensitivity option to TableResolver interface.
nicktobey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add docstrings
- Loading branch information
commit 3ca970a4c5c180932a0a976933d7bc2896c9c15c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added