Skip to content

use unsafe pointer for TextStorage #9994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jycor merged 1 commit into from
Oct 31, 2025
Merged

use unsafe pointer for TextStorage #9994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions go/store/val/value_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ package val
import (
"context"
"database/sql/driver"
"unsafe"

"github.com/dolthub/dolt/go/store/hash"

"github.com/dolthub/go-mysql-server/sql"
"github.com/dolthub/go-mysql-server/sql/types"

"github.com/dolthub/dolt/go/store/hash"
)

const BytePeekLength = 128
Expand Down Expand Up @@ -88,7 +89,7 @@ func (t *TextStorage) Unwrap(ctx context.Context) (string, error) {
if err != nil {
return "", err
}
return string(buf), nil
return *(*string)(unsafe.Pointer(&buf)), nil
}

func (t *TextStorage) UnwrapAny(ctx context.Context) (interface{}, error) {
Expand Down Expand Up @@ -132,7 +133,7 @@ func (t *TextStorage) Value() (driver.Value, error) {
if err != nil {
return "", err
}
return string(buf), nil
return *(*string)(unsafe.Pointer(&buf)), nil
}

type ByteArray struct {
Expand Down Expand Up @@ -198,7 +199,8 @@ func (b *ByteArray) ToString(ctx context.Context) (string, error) {
if len(buf) < toShow {
toShow = len(buf)
}
return string(buf[:toShow]), nil
res := buf[:toShow]
return *(*string)(unsafe.Pointer(&res)), nil
}

// Hash implements sql.AnyWrapper by returning the Dolt hash.
Expand Down
Loading