Skip to content

Fix 8193 err on empty insert vals #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elianddb wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fix 8193 err on empty insert vals #3055

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a2054ca
rm check for vt == 0
elianddb Jun 27, 2025
230f6fd
add err in planbuilder
elianddb Jun 28, 2025
e9900ff
add insert_queries
elianddb Jun 28, 2025
ebf955b
add create table nil default
elianddb Jun 30, 2025
0540edb
add implicit default null
elianddb Jul 1, 2025
a2bffa7
Remove test skip to enable validation
elianddb Jul 8, 2025
887f4c7
Complete fix for issue #8193 - empty INSERT VALUES error handling
elianddb Jul 8, 2025
317599a
Fix generated column restriction and keyless table handling
elianddb Jul 8, 2025
0e17300
Fix keyless table handling - revert overly permissive nullable check
elianddb Jul 8, 2025
e8c50a0
Fix all CI failures - comprehensive schema updates for empty VALUES()
elianddb Jul 8, 2025
fa5bbd7
Fix keyless table schema test expectations
elianddb Jul 8, 2025
ad27497
add no cols tests
elianddb Jul 9, 2025
f70ac7f
fix expected on no cols insert
elianddb Jul 9, 2025
1921bd0
amend to use OkResult constructor
elianddb Jul 9, 2025
a4a2697
fix OkResult objs ref
elianddb Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test skip to enable validation
  • Loading branch information
@elianddb
elianddb committed Jul 8, 2025
commit a2bffa7c7485f7882d0751ff1570d43ce477d0d7
1 change: 0 additions & 1 deletion enginetest/enginetests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,6 @@ func TestInsertIntoErrors(t *testing.T, harness Harness) {

func TestBrokenInsertScripts(t *testing.T, harness Harness) {
for _, script := range queries.InsertBrokenScripts {
t.Skip()
Copy link
Contributor

@jycor jycor Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are all fixed now, move the queries to InsertScripts and and delete the TestBrokenInsertScripts test functions.

TestScript(t, harness, script)
}
}
Expand Down