Skip to content

Allow string truncation when casting to date #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelamayxie merged 3 commits into from
Oct 28, 2025
Merged

Allow string truncation when casting to date #3280

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de838d5
allow truncated strings when cast as date
angelamayxie Oct 24, 2025
5feb06b
add insert invalid date test
angelamayxie Oct 24, 2025
eaa5fd9
add another test
angelamayxie Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
allow truncated strings when cast as date
  • Loading branch information
@angelamayxie
angelamayxie committed Oct 24, 2025
commit de838d50ae791b7e60aa6380f92be3e5ed8e0e8b
6 changes: 6 additions & 0 deletions enginetest/queries/queries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4285,6 +4285,12 @@ SELECT * FROM cte WHERE d = 2;`,
Query: "select cast('2020-01-01 12:34:56.123456' as datetime(6)) > cast('2020-01-01 12:34:56' as datetime)",
Expected: []sql.Row{{true}},
},
{
Query: "select cast('2020-01-01 a' as date)",
ExpectedWarning: 1292,
ExpectedWarningsCount: 1,
Expected: []sql.Row{{time.Date(2020, time.January, 1, 0, 0, 0, 0, time.UTC)}},
},
{
Query: `SELECT * FROM (SELECT * FROM (SELECT * FROM (SELECT * FROM othertable) othertable_one) othertable_two) othertable_three WHERE s2 = 'first'`,
Expected: []sql.Row{
Expand Down
5 changes: 4 additions & 1 deletion sql/expression/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,10 @@ func convertValue(ctx *sql.Context, val interface{}, castTo string, originType s
}
d, _, err := types.Date.Convert(ctx, val)
if err != nil {
return nil, err
if !sql.ErrTruncatedIncorrect.Is(err) {
return nil, err
}
ctx.Warn(mysql.ERTruncatedWrongValue, "%s", err.Error())
}
return d, nil
case ConvertToDatetime:
Expand Down