Merge pull request #439 from dolthub/elian/9887

dolthub/dolt#9887: Fix empty executable comments and add `BINLOG` support and `mariadb` executable comments

Author: elianddb

go/mysql/binlog_event.go

@@ -127,6 +127,9 @@ type BinlogEvent interface {
 
 	// Bytes returns the binary representation of the event
 	Bytes() []byte
+
+	// TypeName returns a human-readable name for the event type.
+	TypeName() string
 }
 
 // BinlogFormat contains relevant data from the FORMAT_DESCRIPTION_EVENT.

go/mysql/binlog_event_common.go

@@ -19,6 +19,7 @@ package mysql
 import (
 	"bytes"
 	"encoding/binary"
+	"fmt"
 
 	binlogdatapb "github.com/dolthub/vitess/go/vt/proto/binlogdata"
 	"github.com/dolthub/vitess/go/vt/proto/vtrpc"
@@ -81,6 +82,40 @@ func (ev binlogEvent) Type() byte {
 	return ev.Bytes()[4]
 }
 
+// TypeName returns a human-readable name for the event type.
+// This matches MariaDB's Log_event::get_type_str() function for consistency.
+func (ev binlogEvent) TypeName() string {
+	eventType := ev.Type()
+	switch eventType {
+	case eQueryEvent:
+		return "Query"
+	case eRotateEvent:
+		return "Rotate"
+	case eFormatDescriptionEvent:
+		return "Format_desc"
+	case eXIDEvent:
+		return "Xid"
+	case eTableMapEvent:
+		return "Table_map"
+	case eWriteRowsEventV1:
+		return "Write_rows_v1"
+	case eUpdateRowsEventV1:
+		return "Update_rows_v1"
+	case eDeleteRowsEventV1:
+		return "Delete_rows_v1"
+	case eWriteRowsEventV2:
+		return "Write_rows"
+	case eUpdateRowsEventV2:
+		return "Update_rows"
+	case eDeleteRowsEventV2:
+		return "Delete_rows"
+	case eMariaGTIDEvent:
+		return "Gtid"
+	default:
+		return fmt.Sprintf("Unknown (type %d)", eventType)
+	}
+}
+
 // Flags returns the flags field from the header.
 func (ev binlogEvent) Flags() uint16 {
 	return binary.LittleEndian.Uint16(ev.Bytes()[17 : 17+2])

go/mysql/binlog_event_filepos.go

@@ -114,6 +114,10 @@ func (ev filePosQueryEvent) StripChecksum(f BinlogFormat) (BinlogEvent, []byte,
 	return ev, nil, nil
 }
 
+func (ev filePosQueryEvent) TypeName() string {
+	return "Query"
+}
+
 //----------------------------------------------------------------------------
 
 // filePosFakeEvent is the base class for fake events.
@@ -253,6 +257,10 @@ func (ev filePosGTIDEvent) StripChecksum(f BinlogFormat) (BinlogEvent, []byte, e
 	return ev, nil, nil
 }
 
+func (ev filePosGTIDEvent) TypeName() string {
+	return "Gtid"
+}
+
 func (ev filePosGTIDEvent) GTID(BinlogFormat) (GTID, bool, error) {
 	return ev.gtid, false, nil
 }

go/mysql/constants.go

@@ -438,116 +438,119 @@ const (
 	ERLockDeadlock       = 1213
 
 	// invalid arg
-	ERUnknownComError              = 1047
-	ERBadNullError                 = 1048
-	ERBadDb                        = 1049
-	ERBadTable                     = 1051
-	ERNonUniq                      = 1052
-	ERWrongFieldWithGroup          = 1055
-	ERWrongGroupField              = 1056
-	ERWrongSumSelect               = 1057
-	ERWrongValueCount              = 1058
-	ERTooLongIdent                 = 1059
-	ERDupFieldName                 = 1060
-	ERDupKeyName                   = 1061
-	ERWrongFieldSpec               = 1063
-	ERParseError                   = 1064
-	EREmptyQuery                   = 1065
-	ERNonUniqTable                 = 1066
-	ERInvalidDefault               = 1067
-	ERMultiplePriKey               = 1068
-	ERTooManyKeys                  = 1069
-	ERTooManyKeyParts              = 1070
-	ERTooLongKey                   = 1071
-	ERKeyColumnDoesNotExist        = 1072
-	ERBlobUsedAsKey                = 1073
-	ERTooBigFieldLength            = 1074
-	ERWrongAutoKey                 = 1075
-	ERWrongFieldTerminators        = 1083
-	ERBlobsAndNoTerminated         = 1084
-	ERTextFileNotReadable          = 1085
-	ERWrongSubKey                  = 1089
-	ERCantRemoveAllFields          = 1090
-	ERUpdateTableUsed              = 1093
-	ERNoTablesUsed                 = 1096
-	ERTooBigSet                    = 1097
-	ERBlobCantHaveDefault          = 1101
-	ERWrongDbName                  = 1102
-	ERWrongTableName               = 1103
-	ERUnknownProcedure             = 1106
-	ERWrongParamCountToProcedure   = 1107
-	ERWrongParametersToProcedure   = 1108
-	ERFieldSpecifiedTwice          = 1110
-	ERInvalidGroupFuncUse          = 1111
-	ERTableMustHaveColumns         = 1113
-	ERUnknownCharacterSet          = 1115
-	ERTooManyTables                = 1116
-	ERTooManyFields                = 1117
-	ERTooBigRowSize                = 1118
-	ERWrongOuterJoin               = 1120
-	ERNullColumnInIndex            = 1121
-	ERFunctionNotDefined           = 1128
-	ERWrongValueCountOnRow         = 1136
-	ERInvalidUseOfNull             = 1138
-	ERRegexpError                  = 1139
-	ERMixOfGroupFuncAndFields      = 1140
-	ERIllegalGrantForTable         = 1144
-	ERSyntaxError                  = 1149
-	ERWrongColumnName              = 1166
-	ERWrongKeyColumn               = 1167
-	ERBlobKeyWithoutLength         = 1170
-	ERPrimaryCantHaveNull          = 1171
-	ERTooManyRows                  = 1172
-	ERLockOrActiveTransaction      = 1192
-	ERUnknownSystemVariable        = 1193
-	ERSetConstantsOnly             = 1204
-	ERWrongArguments               = 1210
-	ERWrongUsage                   = 1221
-	ERWrongNumberOfColumnsInSelect = 1222
-	ERDupArgument                  = 1225
-	ERLocalVariable                = 1228
-	ERGlobalVariable               = 1229
-	ERWrongValueForVar             = 1231
-	ERWrongTypeForVar              = 1232
-	ERVarCantBeRead                = 1233
-	ERCantUseOptionHere            = 1234
-	ERIncorrectGlobalLocalVar      = 1238
-	ERWrongFKDef                   = 1239
-	ERKeyRefDoNotMatchTableRef     = 1240
-	ERCyclicReference              = 1245
-	ERIllegalReference             = 1247
-	ERDerivedMustHaveAlias         = 1248
-	ERTableNameNotAllowedHere      = 1250
-	ERCollationCharsetMismatch     = 1253
-	ERWarnDataTruncated            = 1265
-	ERCantAggregate2Collations     = 1267
-	ERCantAggregate3Collations     = 1270
-	ERCantAggregateNCollations     = 1271
-	ERVariableIsNotStruct          = 1272
-	ERUnknownCollation             = 1273
-	ERWrongNameForIndex            = 1280
-	ERWrongNameForCatalog          = 1281
-	ERBadFTColumn                  = 1283
-	ERTruncatedWrongValue          = 1292
-	ERTooMuchAutoTimestampCols     = 1293
-	ERInvalidOnUpdate              = 1294
-	ERUnknownTimeZone              = 1298
-	ERInvalidCharacterString       = 1300
-	ERQueryInterrupted             = 1317
-	ERTruncatedWrongValueForField  = 1366
-	ERIllegalValueForType          = 1367
-	ERDataTooLong                  = 1406
-	ErrWrongValueForType           = 1411
-	ERForbidSchemaChange           = 1450
-	ERWrongValue                   = 1525
-	ERDataOutOfRange               = 1690
-	ERInvalidJSONText              = 3140
-	ERInvalidJSONTextInParams      = 3141
-	ERInvalidJSONBinaryData        = 3142
-	ERInvalidJSONCharset           = 3144
-	ERInvalidCastToJSON            = 3147
-	ERJSONValueTooBig              = 3150
-	ERJSONDocumentTooDeep          = 3157
+	ERUnknownComError                               = 1047
+	ERBadNullError                                  = 1048
+	ERBadDb                                         = 1049
+	ERBadTable                                      = 1051
+	ERNonUniq                                       = 1052
+	ERWrongFieldWithGroup                           = 1055
+	ERWrongGroupField                               = 1056
+	ERWrongSumSelect                                = 1057
+	ERWrongValueCount                               = 1058
+	ERTooLongIdent                                  = 1059
+	ERDupFieldName                                  = 1060
+	ERDupKeyName                                    = 1061
+	ERWrongFieldSpec                                = 1063
+	ERParseError                                    = 1064
+	EREmptyQuery                                    = 1065
+	ERNonUniqTable                                  = 1066
+	ERInvalidDefault                                = 1067
+	ERMultiplePriKey                                = 1068
+	ERTooManyKeys                                   = 1069
+	ERTooManyKeyParts                               = 1070
+	ERTooLongKey                                    = 1071
+	ERKeyColumnDoesNotExist                         = 1072
+	ERBlobUsedAsKey                                 = 1073
+	ERTooBigFieldLength                             = 1074
+	ERWrongAutoKey                                  = 1075
+	ERWrongFieldTerminators                         = 1083
+	ERBlobsAndNoTerminated                          = 1084
+	ERTextFileNotReadable                           = 1085
+	ERWrongSubKey                                   = 1089
+	ERCantRemoveAllFields                           = 1090
+	ERUpdateTableUsed                               = 1093
+	ERNoTablesUsed                                  = 1096
+	ERTooBigSet                                     = 1097
+	ERBlobCantHaveDefault                           = 1101
+	ERWrongDbName                                   = 1102
+	ERWrongTableName                                = 1103
+	ERUnknownProcedure                              = 1106
+	ERWrongParamCountToProcedure                    = 1107
+	ERWrongParametersToProcedure                    = 1108
+	ERFieldSpecifiedTwice                           = 1110
+	ERInvalidGroupFuncUse                           = 1111
+	ERTableMustHaveColumns                          = 1113
+	ERUnknownCharacterSet                           = 1115
+	ERTooManyTables                                 = 1116
+	ERTooManyFields                                 = 1117
+	ERTooBigRowSize                                 = 1118
+	ERWrongOuterJoin                                = 1120
+	ERNullColumnInIndex                             = 1121
+	ERFunctionNotDefined                            = 1128
+	ERWrongValueCountOnRow                          = 1136
+	ERInvalidUseOfNull                              = 1138
+	ERRegexpError                                   = 1139
+	ERMixOfGroupFuncAndFields                       = 1140
+	ERIllegalGrantForTable                          = 1144
+	ERSyntaxError                                   = 1149
+	ERWrongColumnName                               = 1166
+	ERWrongKeyColumn                                = 1167
+	ERBlobKeyWithoutLength                          = 1170
+	ERPrimaryCantHaveNull                           = 1171
+	ERTooManyRows                                   = 1172
+	ERLockOrActiveTransaction                       = 1192
+	ERUnknownSystemVariable                         = 1193
+	ERSetConstantsOnly                              = 1204
+	ERWrongArguments                                = 1210
+	ERWrongUsage                                    = 1221
+	ERWrongNumberOfColumnsInSelect                  = 1222
+	ERDupArgument                                   = 1225
+	ERLocalVariable                                 = 1228
+	ERGlobalVariable                                = 1229
+	ERWrongValueForVar                              = 1231
+	ERWrongTypeForVar                               = 1232
+	ERVarCantBeRead                                 = 1233
+	ERCantUseOptionHere                             = 1234
+	ERIncorrectGlobalLocalVar                       = 1238
+	ERWrongFKDef                                    = 1239
+	ERKeyRefDoNotMatchTableRef                      = 1240
+	ERCyclicReference                               = 1245
+	ERIllegalReference                              = 1247
+	ERDerivedMustHaveAlias                          = 1248
+	ERTableNameNotAllowedHere                       = 1250
+	ERCollationCharsetMismatch                      = 1253
+	ERWarnDataTruncated                             = 1265
+	ERCantAggregate2Collations                      = 1267
+	ERCantAggregate3Collations                      = 1270
+	ERCantAggregateNCollations                      = 1271
+	ERVariableIsNotStruct                           = 1272
+	ERUnknownCollation                              = 1273
+	ERWrongNameForIndex                             = 1280
+	ERWrongNameForCatalog                           = 1281
+	ERBadFTColumn                                   = 1283
+	ERTruncatedWrongValue                           = 1292
+	ERTooMuchAutoTimestampCols                      = 1293
+	ERInvalidOnUpdate                               = 1294
+	ERUnknownTimeZone                               = 1298
+	ERInvalidCharacterString                        = 1300
+	ERQueryInterrupted                              = 1317
+	ERTruncatedWrongValueForField                   = 1366
+	ERIllegalValueForType                           = 1367
+	ERDataTooLong                                   = 1406
+	ErrWrongValueForType                            = 1411
+	ERForbidSchemaChange                            = 1450
+	ERWrongValue                                    = 1525
+	ERBase64DecodeError                             = 1575
+	ERNoFormatDescriptionEventBeforeBinlogStatement = 1609
+	ERDataOutOfRange                                = 1690
+	EROnlyFDAndRBREventsAllowedInBinlogStatement    = 1730
+	ERInvalidJSONText                               = 3140
+	ERInvalidJSONTextInParams                       = 3141
+	ERInvalidJSONBinaryData                         = 3142
+	ERInvalidJSONCharset                            = 3144
+	ERInvalidCastToJSON                             = 3147
+	ERJSONValueTooBig                               = 3150
+	ERJSONDocumentTooDeep                           = 3157
 
 	// max execution time exceeded
 	ERQueryTimeout = 3024

go/vt/sqlparser/ast.go

@@ -480,6 +480,7 @@ func (*RollbackSavepoint) iStatement() {}
 func (*ReleaseSavepoint) iStatement()  {}
 func (*LockTables) iStatement()        {}
 func (*UnlockTables) iStatement()      {}
+func (*Binlog) iStatement()            {}
 
 // ParenSelect can actually not be a top level statement,
 // but we have to allow it because it's a requirement
@@ -8324,3 +8325,41 @@ func (d InjectedStatement) SetAuthTargetNames(targetNames []string) {
 func (d InjectedStatement) SetExtra(extra any) {
 	d.Auth.Extra = extra
 }
+
+// Binlog represents a BINLOG statement that executes base64-encoded binary log events.
+type Binlog struct {
+	Base64Str string
+	Auth      AuthInformation
+}
+
+var _ AuthNode = (*Binlog)(nil)
+
+// Format formats the node.
+func (node *Binlog) Format(buf *TrackedBuffer) {
+	buf.Myprintf("binlog '%s'", node.Base64Str)
+}
+
+// GetAuthInformation returns the authorization information for this node.
+func (node *Binlog) GetAuthInformation() AuthInformation {
+	return node.Auth
+}
+
+// SetAuthType sets the authorization type.
+func (node *Binlog) SetAuthType(authType string) {
+	node.Auth.AuthType = authType
+}
+
+// SetAuthTargetType sets the authorization target type.
+func (node *Binlog) SetAuthTargetType(targetType string) {
+	node.Auth.TargetType = targetType
+}
+
+// SetAuthTargetNames sets the authorization target names.
+func (node *Binlog) SetAuthTargetNames(targetNames []string) {
+	node.Auth.TargetNames = targetNames
+}
+
+// SetExtra sets extra authorization information.
+func (node *Binlog) SetExtra(extra any) {
+	node.Auth.Extra = extra
+}

go/vt/sqlparser/auth.go

@@ -58,6 +58,7 @@ const (
 	AuthType_ALTER                 = "ALTER"
 	AuthType_ALTER_ROUTINE         = "ALTER_ROUTINE"
 	AuthType_ALTER_USER            = "ALTER_USER"
+	AuthType_BINLOG                = "BINLOG"
 	AuthType_CALL                  = "CALL"
 	AuthType_CREATE                = "CREATE"
 	AuthType_CREATE_ROLE           = "CREATE_ROLE"