dolthub/dolt#9887: Fix empty executable comments and add BINLOG support and mariadb executable comments
#439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianddb
changed the title
BINLOG and mariadb executable commentsBINLOG and mariadb executable comments
elianddb
changed the title
BINLOG and mariadb executable commentsBINLOG support and mariadb executable comments
elianddb
force-pushed
the
elian/9887
branch
2 times, most recently
from
7a4665b to
02e4ea1
Compare
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#9887
TypeName()tobinlogEventobjects for error message creation on the frontend, i.e.go-mysql-server.ERBase64DecodeError = 1575,ERNoFormatDescriptionEventBeforeBinlogStatement = 1609, andEROnlyFDAndRBREventsAllowedInBinlogStatement = 1730forBinlogstatements error handling.Binlogstatement parser support.mariadbexecutable comment support and fix handling of empty comments, i.e./*!*/and/*M!*/.