Skip to content

Conversation

@cremor
Copy link
Contributor

@cremor cremor commented May 15, 2024

Update a few outdated links to the Swagger UI repository and add missing extension methods on SwaggerUIOptions.

I also thought about adding mentions to the properties directly on SwaggerUIOptions (e.g. HeadContent) but decided against it for now. Those would need some additinal warnings because otherwise you might undo your previous modifications done by the extension methods again.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (a29ba36) to head (a0ea07f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2883   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          72       72           
  Lines        2698     2698           
  Branches      426      426           
=======================================
  Hits         2430     2430           
  Misses        268      268           
Flag Coverage Δ
Linux 90.06% <ø> (ø)
Windows 90.06% <ø> (ø)
macOS 90.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Collaborator

Thanks. I wouldn't do any more PRs to add further new content (tweaks/fixes are fine) - we think the README has gotten too big at this point and want to rework it. We just haven't worked out exactly what we want to do instead yet.

@martincostello martincostello merged commit f16fa78 into domaindrivendev:master May 15, 2024
This was referenced Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants