-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
.NET 10 preparation #3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
.NET 10 preparation #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick refactoring from #3283 to make multi-targeting easier for ASP.NET Core 10 and Microsoft.OpenApi v2.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3285 +/- ##
==========================================
- Coverage 86.08% 83.56% -2.53%
==========================================
Files 79 77 -2
Lines 3378 3224 -154
Branches 588 559 -29
==========================================
- Hits 2908 2694 -214
- Misses 470 530 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Make Verify snapshots unique per target framework. This is to when .NET 10 introduces OpenAPI 3.1, it doesn't cause issues with the snapshots being intentionally different.
Apply IDE suggestion to use collection expressions.
Shorten test names to avoid `MAX_PATH` issues on Windows in GitHub Actions.
Bump coverlet, Microsoft.NET.Test.Sdk, ReportGenerator, and xunit to their latest stable versions.
- Update more NuGet package version overrides for tests to the latest versions. - Drop leftover `net6.0` reference in tests.
This was referenced Jul 29, 2025
This was referenced Nov 17, 2025
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick refactoring from #3283 to make multi-targeting easier for ASP.NET Core 10 and Microsoft.OpenApi v2.
This PR will be easiest to review one commit at a time, as the second commit effectively just renames all the non-TFM'd snapshots to one of the TFMs, then the other files are just copies of the those with the name of the other TFM.