Add tests for RangeAttribute and respect ParseLimitsInInvariantCulture property #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Port tests for `[RangeAttribute]` from #3283. - Respect `RangeAttribute.ParseLimitsInInvariantCulture`. - Refactor to avoid redundant reassignment.
- Avoid converting `int` values to a string and re-parsing. - Add test case for decimal values.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3448 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 110 110
Lines 3827 3829 +2
Branches 713 713
=======================================
+ Hits 3580 3582 +2
Misses 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martincostello
changed the title
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive tests for RangeAttribute parsing across different cultures and updates the schema extension to honor the ParseLimitsInInvariantCulture flag while removing redundant parsing logic.
- Introduces
OpenApiSchemaExtensionsTestscovering integer, floating, and decimal ranges under various cultures. - Refactors
ApplyRangeAttributeto directly convert limits using the correct culture and eliminate extraToString()/Parsecalls. - Adds a
CultureSwitcherhelper to set and restoreCurrentCulture.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/Swashbuckle.AspNetCore.SwaggerGen.Test/SwaggerGenerator/OpenApiSchemaExtensionsTests.cs | New tests for RangeAttribute including culture-specific parsing and an empty‐string culture helper. |
| src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/OpenApiSchemaExtensions.cs | Updated ApplyRangeAttribute to use Convert.ToDecimal with culture and removed redundant parsing. |
test/Swashbuckle.AspNetCore.SwaggerGen.Test/SwaggerGenerator/OpenApiSchemaExtensionsTests.cs
Show resolved
Hide resolved
test/Swashbuckle.AspNetCore.SwaggerGen.Test/SwaggerGenerator/OpenApiSchemaExtensionsTests.cs
Show resolved
Hide resolved
This was referenced Jul 28, 2025
This was referenced Nov 12, 2025
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
TesterMarti/skills-secure-repository-supply-chain#13
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RangeAttribute]from Support .NET 10 #3283.RangeAttribute.ParseLimitsInInvariantCulture.intvalues to a string and re-parsing.