Skip to content

Conversation

@martincostello
Copy link
Collaborator

Supersedes #3662 to resolve #3659.

Wajahat Ahmad and others added 2 commits November 18, 2025 13:21
- Apply review comments from #3662.
- Tweak implementation.
@martincostello martincostello added this to the v10.1.0 milestone Dec 10, 2025
Copilot AI review requested due to automatic review settings December 10, 2025 10:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds nullability annotations to the TryLookupByType method to improve null-safety analysis by indicating that the out parameter is guaranteed to be non-null when the method returns true. The implementation has been refactored to support this annotation pattern.

  • Added [NotNullWhen(true)] attribute to the referenceSchema out parameter
  • Refactored TryLookupByType implementation to explicitly initialize the out parameter before conditional assignment
  • Removed private set from Schemas property accessor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add missing space.
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.67%. Comparing base (e28f031) to head (ac97564).
⚠️ Report is 63 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3719      +/-   ##
==========================================
+ Coverage   94.53%   94.67%   +0.13%     
==========================================
  Files         111      111              
  Lines        3861     3868       +7     
  Branches      778      780       +2     
==========================================
+ Hits         3650     3662      +12     
+ Misses        211      206       -5     
Flag Coverage Δ
Linux 94.67% <100.00%> (+0.13%) ⬆️
Windows 94.67% <100.00%> (+0.13%) ⬆️
macOS 94.67% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello enabled auto-merge (squash) December 10, 2025 11:02
@martincostello martincostello enabled auto-merge (squash) December 10, 2025 11:06
@martincostello martincostello merged commit 4df3d53 into master Dec 10, 2025
14 checks passed
@martincostello martincostello deleted the gh-3659 branch December 10, 2025 11:06
This was referenced Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please annotate SchemaRepository.TryLookupByType

2 participants