This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Updates kubebuilder dep #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
really update sigs.k8s.io/controller-runtime and it's dependencies also generated deep copy for PluginData (we missed this earlier)
adds missing docs to API types so that they provide a full description in the CRD residing a K8s cluster.
steved
approved these changes
Jun 25, 2020
Contributor
steved
left a comment
steved
left a comment
There was a problem hiding this comment.
Changes LGTM, but I think I'm missing something with:
also generated deep copy for PluginData (we missed this earlier)
steved
added a commit
that referenced
this pull request
Jun 26, 2020
kubernetes-sigs/controller-runtime#446 removed the default and #30 updated kubebuilder to v0.5.0 when this was released.
steved
added a commit
that referenced
this pull request
Jul 1, 2020
kubernetes-sigs/controller-runtime#446 removed the default and #30 updated kubebuilder to v0.5.0 when this was released.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
really only updates
sigs.k8s.io/controller-runtimeand it's dependenciesalso generated deep copy for PluginData (we missed this earlier)
addresses #17 and will bring in a couple of wanted bugfixes