feat(chores): add user timezone uppon chore creation #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meauxt
reviewed
May 31, 2025
| skipWaiting: true, // Force the waiting service worker to become the active service worker | ||
| clientsClaim: true, // Take control of uncontrolled clients as soon as the service worker becomes active | ||
| maximumFileSizeToCacheInBytes: 6000000, // 6MB | ||
| navigateFallbackDenylist: [/^\/eapi\/.+/], // Prevent caching of external API routes |
Contributor
There was a problem hiding this comment.
am not sure why we need this ? for eapi
Author
There was a problem hiding this comment.
Because the service worker serves requests from cache and we end up being served the 404 error page for API routes.
The only way to have the actual API response when directly accessing an API endpoint is by doing a hard refresh in the browser. It's the same for /apiendpoint by the way (you can try the /api/v1/resource endpoint in your browser) but since /eapi is supposed to be an external API I think it shouldn't be cached.
I was playing with the /eapi route but I changed my strategy so I won't be using it in the end, if you don't want this change it's fine for me.
meauxt
reviewed
May 31, 2025
baprx
force-pushed
the
feat/chores-timezone
branch
from
70afcf2 to
e0e3bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.