Skip to content

Remove problematic factory.create.logger /7 #30249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rick-Anderson merged 14 commits into from
Sep 7, 2023
Merged

Remove problematic factory.create.logger /7 #30249

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b48919a
Remove problematic factory.create.logger /7
Rick-Anderson Sep 6, 2023
0f1fc45
Remove problematic factory.create.logger /7
Rick-Anderson Sep 6, 2023
c2cff2d
Remove problematic factory.create.logger /7
Rick-Anderson Sep 6, 2023
a3c8638
Update aspnetcore/fundamentals/logging/index/samples/6.x/WebLog/Progr…
Rick-Anderson Sep 6, 2023
c49cf44
React to feedback
Rick-Anderson Sep 6, 2023
1e7d11c
React to feedback
Rick-Anderson Sep 6, 2023
0d5a3fd
React to feedback
Rick-Anderson Sep 6, 2023
814b79f
React to feedback
Rick-Anderson Sep 7, 2023
bac2b3d
React to feedback
Rick-Anderson Sep 7, 2023
3800d37
React to feedback
Rick-Anderson Sep 7, 2023
9be3293
React to feedback
Rick-Anderson Sep 7, 2023
6fa4c50
Apply suggestions from code review
Rick-Anderson Sep 7, 2023
cf690e6
React to feedback
Rick-Anderson Sep 7, 2023
7245cc3
React to feedback
Rick-Anderson Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
React to feedback
  • Loading branch information
@Rick-Anderson
Rick-Anderson committed Sep 7, 2023
commit 9be3293a7cff7d41ffa80c9315ed38ee34306f59
2 changes: 0 additions & 2 deletions aspnetcore/fundamentals/logging/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,8 +883,6 @@ The logging libraries implicitly create a scope object with `SpanId`, `TraceId`,

If the `traceparent` http request header is set, the `ParentId` in the log scope shows the W3C `parent-id` from in-bound `traceparent` header and the `SpanId` in the log scope shows the updated `parent-id` for the next out-bound step/span. For more information, see [Mutating the traceparent Field](https://www.w3.org/TR/trace-context/#mutating-the-traceparent-field).

<!-- Add warning here once warning is approved -->

## Create a custom logger

To create a custom logger, see [Implement a custom logging provider in .NET](/dotnet/core/extensions/custom-logging-provider).
Expand Down