Skip to content

PerfCollect diagnoser #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 26 commits into from
Sep 29, 2022
Merged

PerfCollect diagnoser #2117

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
7c09e43
initial LttngProfiler implementation
adamsitnik Jun 9, 2019
c4921ad
download the script to the right folder
adamsitnik Jun 9, 2019
c59b96d
escepe the arguments, wait until it starts actual collection, don't g…
adamsitnik Jun 9, 2019
4171885
wait until the script ends post-processing
adamsitnik Jun 9, 2019
77e3a52
use Mono.Posix to send SIGINT (Ctrl+C) to the script
adamsitnik Jun 9, 2019
11c5e06
more changes
adamsitnik Jul 1, 2019
eedf8c0
Merge remote-tracking branch 'origin/master' into perfCollectDiagnoser
adamsitnik Mar 3, 2020
2c63c4c
remove duplicated code
adamsitnik Mar 3, 2020
c77e7df
add perfcollect to the resources, don't download it
adamsitnik Mar 3, 2020
93330c2
update doc link
adamsitnik Mar 3, 2020
bd7ceb0
use the new start and stop commands
adamsitnik Mar 3, 2020
8472f20
use the new install -force option which allows us to avoid user being…
adamsitnik Mar 16, 2020
f08473b
Merge branch 'master' into perfCollectDiagnoser
adamsitnik Sep 20, 2022
c2d8bf7
refresh perfcollect
adamsitnik Sep 20, 2022
4ffdf5d
use collect command, stop in with Ctrl+C by sending SIGINT
adamsitnik Sep 22, 2022
a6086f8
add an attribute and a sample
adamsitnik Sep 22, 2022
e85c830
enable BDN event source
adamsitnik Sep 22, 2022
d2db654
emit an error when perfcollect finishes sooner than expected (most li…
adamsitnik Sep 23, 2022
220dcde
escape the arguments, store the result only if file was created, get …
adamsitnik Sep 26, 2022
194f4bf
turn off precompiled code to resolve framework symbols without using …
adamsitnik Sep 27, 2022
c0d692a
install dotnet symbols to get symbols for native runtime parts
adamsitnik Sep 27, 2022
7191b6b
add workaround for https://github.com/dotnet/runtime/issues/71786
adamsitnik Sep 28, 2022
bb0c66d
download symbols for all .so files
adamsitnik Sep 28, 2022
5b04d07
polishing: new short name (perf instead PC), running for multiple run…
adamsitnik Sep 28, 2022
5201ed1
don't turn off precompiled code
adamsitnik Sep 28, 2022
7819a20
final polishing before merging
adamsitnik Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't turn off precompiled code
  • Loading branch information
@adamsitnik
adamsitnik committed Sep 28, 2022
commit 5201ed1eb153cdb029481b4e30ce00c7c0b0c48a
2 changes: 0 additions & 2 deletions src/BenchmarkDotNet/Extensions/ProcessExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ internal static void SetEnvironmentVariables(this ProcessStartInfo start, Benchm
start.EnvironmentVariables["COMPlus_EnableEventLog"] = "1";
// enable BDN Event Source (https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/linux-performance-tracing.md#filtering)
start.EnvironmentVariables["COMPlus_EventSourceFilter"] = EngineEventSource.SourceName;
Copy link
Member Author

@adamsitnik adamsitnik Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianrob if I want to enable all events for given event source, is setting COMPlus_EventSourceFilter enough?

The definition of event source that I care about:

BenchmarkDotNet/src/BenchmarkDotNet/Engines/EngineEventSource.cs

Lines 7 to 10 in 21a2940

[EventSource(Name = EngineEventSource.SourceName)]
public class EngineEventSource : EventSource
{
public const string SourceName = "BenchmarkDotNet.EngineEventSource";

Copy link
Member

@brianrob brianrob Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that and setting COMPlus_EnableEventLog=1. If you set COMPlus_EventSourceFilter to the EventSource that you want to capture, this will disable all other EventSources from being sent through to LTTng to avoid the cost of emitting all other EventSource events that may not be needed.

// turn off precompiled code to resolve framework symbols without using crossgen(2) (https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/linux-performance-tracing.md#alternative-turn-off-use-of-precompiled-code)
start.EnvironmentVariables["COMPlus_ZapDisable"] = "1";
// workaround for https://github.com/dotnet/runtime/issues/71786, will be solved by next perf version
start.EnvironmentVariables["DOTNET_EnableWriteXorExecute"] = "0";
}
Expand Down