[Mono] Disable LLVM JIT #2134
Merged
[Mono] Disable LLVM JIT #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just delete the offending code instead of commenting it out? I don't think we want to check that into master. |
Member
Author
Since we are turning it back on again in the near future, I thought it was easier to just comment it out. If that doesn't fit the coding guideline, I could delete the commented code as well. |
adamsitnik
reviewed
Oct 6, 2022
adamsitnik
approved these changes
Oct 6, 2022
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @fanyang-mono !
Member
Author
|
@naricc @adamsitnik I don't think the CI failures are related to my change. Could you confirm? |
Member
I confirm they are not related to your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dotnet/performance#2625
Since the merge of https://github.com/dotnet/runtime/pull/75055/files, Mono llvm-jit has been disabled. This PR is to react to that.