Skip to content

Issue2394 multiple markdown exporters not possible even with different names #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 3 commits into from
Aug 10, 2023
Merged

Issue2394 multiple markdown exporters not possible even with different names #2395

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cb0a9e
Merge exporters by exporter.Name instead of exporter.GetType()
bstordrup Aug 9, 2023
8b7cd93
Added test that MarkdownExporter.GitHub and MarkdownExporter.Atlassia…
bstordrup Aug 9, 2023
bf711a4
Fixing unintentional move of usings
bstordrup Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added test that MarkdownExporter.GitHub and MarkdownExporter.Atlassia… 
…n are both accepted in the merged configuration
  • Loading branch information
@bstordrup
bstordrup committed Aug 9, 2023
commit 8b7cd93b88ec78826acf71a8bbafb3131c23ad90
15 changes: 14 additions & 1 deletion tests/BenchmarkDotNet.Tests/Configs/ImmutableConfigTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,19 @@ public void DuplicateExportersAreExcluded()
Assert.Same(MarkdownExporter.GitHub, final.GetExporters().Single());
}

[Fact]
public void MultipleExportersOfSameTypeWithDifferentNamesAreAccepted()
{
var mutable = ManualConfig.CreateEmpty();

mutable.AddExporter(MarkdownExporter.GitHub);
mutable.AddExporter(MarkdownExporter.Atlassian);

var final = ImmutableConfigBuilder.Create(mutable);

Assert.Equal(2, final.GetExporters().Count());
}

[Fact]
public void DuplicateAnalyzersAreExcluded()
{
Expand Down Expand Up @@ -380,7 +393,7 @@ private static ImmutableConfig[] AddLeftToTheRightAndRightToTheLef(ManualConfig
var leftAddedToTheRight = ManualConfig.Create(right);
leftAddedToTheRight.Add(left);

return new[]{ rightAddedToLeft.CreateImmutableConfig(), leftAddedToTheRight.CreateImmutableConfig() };
return new[] { rightAddedToLeft.CreateImmutableConfig(), leftAddedToTheRight.CreateImmutableConfig() };
}

public class TestExporter : IExporter, IExporterDependencies
Expand Down