Skip to content

Fix linux crash from disassembler #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timcassell merged 7 commits into from
Sep 22, 2023
Merged

Fix linux crash from disassembler #2413

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a3cff2
Update dac vulnerable version.
timcassell Aug 21, 2023
5fd7ed8
Skip 0 and -1 addresses.
timcassell Aug 21, 2023
c67eabd
Check for minimum address.
timcassell Aug 23, 2023
3a988d1
Read file instead of bash.
timcassell Aug 23, 2023
383ab60
Use SystemPageSize
timcassell Aug 24, 2023
9214838
Add OS validation.
timcassell Aug 24, 2023
6524ca2
Some cleanup.
timcassell Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update dac vulnerable version.
  • Loading branch information
@timcassell
timcassell committed Aug 21, 2023
commit 5a3cff2d2ce76ed105d528eaec10d192bbb18110
6 changes: 3 additions & 3 deletions src/BenchmarkDotNet/Disassemblers/ClrMdV2Disassembler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ namespace BenchmarkDotNet.Disassemblers
internal abstract class ClrMdV2Disassembler
{
// Translating an address to a method can cause AV and a process crash (https://github.com/dotnet/BenchmarkDotNet/issues/2070).
// It was fixed in https://github.com/dotnet/runtime/pull/79846,
// and most likely will be backported to 7.0.2 very soon (https://github.com/dotnet/runtime/pull/79862).
protected static readonly bool IsVulnerableToAvInDac = !RuntimeInformation.IsWindows() && Environment.Version < new Version(7, 0, 2);
// It was partially fixed in https://github.com/dotnet/runtime/pull/79846,
// fully fixed in https://github.com/dotnet/runtime/pull/90797.
protected static readonly bool IsVulnerableToAvInDac = !RuntimeInformation.IsWindows() && Environment.Version < new Version(8, 0);

internal DisassemblyResult AttachAndDisassemble(Settings settings)
{
Expand Down