-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add event processor functionality #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
ab86077
313ebf1
aa693f6
24872ec
3f0936d
dca4fc7
9a2c9d4
c30931f
916d9a5
d78d33d
e9d3deb
2c2fc9b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ public class ManualConfig : IConfig | |
| private readonly HashSet<HardwareCounter> hardwareCounters = new HashSet<HardwareCounter>(); | ||
| private readonly List<IFilter> filters = new List<IFilter>(); | ||
| private readonly List<BenchmarkLogicalGroupRule> logicalGroupRules = new List<BenchmarkLogicalGroupRule>(); | ||
| private readonly List<EventProcessorBase> eventProcessors = new List<EventProcessorBase>(); | ||
| private readonly List<EventProcessor> eventProcessors = new List<EventProcessor>(); | ||
| private readonly List<IColumnHidingRule> columnHidingRules = new List<IColumnHidingRule>(); | ||
|
|
||
| public IEnumerable<IColumnProvider> GetColumnProviders() => columnProviders; | ||
|
|
@@ -47,7 +47,7 @@ public class ManualConfig : IConfig | |
| public IEnumerable<HardwareCounter> GetHardwareCounters() => hardwareCounters; | ||
| public IEnumerable<IFilter> GetFilters() => filters; | ||
| public IEnumerable<BenchmarkLogicalGroupRule> GetLogicalGroupRules() => logicalGroupRules; | ||
| public IEnumerable<EventProcessorBase> GetEventProcessors() => eventProcessors; | ||
| public IEnumerable<EventProcessor> GetEventProcessors() => eventProcessors; | ||
| public IEnumerable<IColumnHidingRule> GetColumnHidingRules() => columnHidingRules; | ||
|
|
||
| [PublicAPI] public ConfigOptions Options { get; set; } | ||
|
|
@@ -224,7 +224,7 @@ public ManualConfig AddLogicalGroupRules(params BenchmarkLogicalGroupRule[] rule | |
| return this; | ||
| } | ||
|
|
||
| public ManualConfig AddEventProcessor(EventProcessorBase eventProcessor) | ||
| public ManualConfig AddEventProcessor(EventProcessor eventProcessor) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
While this may be true, this makes it the only one of the |
||
| { | ||
| this.eventProcessors.Add(eventProcessor); | ||
| return this; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,13 +7,13 @@ | |
|
|
||
| namespace BenchmarkDotNet.EventProcessors | ||
| { | ||
| public abstract class EventProcessorBase | ||
| public abstract class EventProcessor | ||
| { | ||
| public virtual void OnStartValidationStage() { } | ||
| public virtual void OnValidationError(ValidationError validationError) { } | ||
| public virtual void OnEndValidationStage() { } | ||
| public virtual void OnStartBuildStage(IReadOnlyList<BuildPartition> partitions) { } | ||
| public virtual void OnBuildComplete(BuildPartition benchmarkCase, BuildResult buildResult) { } | ||
| public virtual void OnBuildComplete(BuildPartition partition, BuildResult buildResult) { } | ||
| public virtual void OnEndBuildStage() { } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is the difference between
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that is the difference between them. |
||
| public virtual void OnStartRunStage() { } | ||
| public virtual void OnStartRunBenchmarksInType(Type type, IReadOnlyList<BenchmarkCase> benchmarks) { } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.