Skip to content

More nullability warnings fixes #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyAkinshin merged 7 commits into from
Oct 3, 2023
Merged

More nullability warnings fixes #2421

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b7c179
Enabled nullability for BenchmarkDotNet.Diagnostics.dotTrace.csproj
alinasmirnova Sep 1, 2023
7499189
Fixed nullability warnings in methods signatures
alinasmirnova Sep 3, 2023
9c2d634
Removed CanBeNull attribute
alinasmirnova Sep 3, 2023
aaf8607
Fixed warnings on null assignments
alinasmirnova Sep 3, 2023
68a9e01
Fixed warnings in EngineEventLogParser
alinasmirnova Sep 4, 2023
3a86aad
Removed an unnecessary check
alinasmirnova Sep 4, 2023
ddca628
Fixed empty catch warning
alinasmirnova Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed CanBeNull attribute
  • Loading branch information
@alinasmirnova
alinasmirnova committed Sep 3, 2023
commit 9c2d634f693f37b74fbfad25feaeff342e02a764
6 changes: 2 additions & 4 deletions tests/BenchmarkDotNet.Tests/XUnit/EnvRequirementChecker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@ namespace BenchmarkDotNet.Tests.XUnit;

public static class EnvRequirementChecker
{
[CanBeNull]
public static string GetSkip(params EnvRequirement[] requirements) => requirements.Select(GetSkip).FirstOrDefault(skip => skip != null);
public static string? GetSkip(params EnvRequirement[] requirements) => requirements.Select(GetSkip).FirstOrDefault(skip => skip != null);

[CanBeNull]
internal static string GetSkip(EnvRequirement requirement) => requirement switch
internal static string? GetSkip(EnvRequirement requirement) => requirement switch
{
EnvRequirement.WindowsOnly => RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? null : "Windows-only test",
EnvRequirement.NonWindows => !RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? null : "Non-Windows test",
Expand Down