Skip to content

[Bug Fix] Custom SimpleJob Id ignored #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyAkinshin merged 3 commits into from
Jan 5, 2024
Merged

[Bug Fix] Custom SimpleJob Id ignored #2491

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69390e9
Fixed job name bug
MattFromRVA Jan 2, 2024
8ac913b
updating some tests
MattFromRVA Jan 2, 2024
b85a67e
Updated test.
MattFromRVA Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updated test.
  • Loading branch information
@MattFromRVA
MattFromRVA committed Jan 3, 2024
commit b85a67e6cb455ff53c4b617f2e4b9bd97c67bba8
2 changes: 1 addition & 1 deletion tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public void UserCanSpecifyMultipleCoreRunPaths()
Assert.Equal(2, jobs.Length);
Assert.Single(jobs.Where(job => job.GetToolchain() is CoreRunToolchain toolchain && toolchain.SourceCoreRun.FullName == fakeCoreRunPath_1));
Assert.Single(jobs.Where(job => job.GetToolchain() is CoreRunToolchain toolchain && toolchain.SourceCoreRun.FullName == fakeCoreRunPath_2));
Assert.Equal(2, jobs.Select(job => job.Id).Distinct().Count()); // each job must have a unique ID

}

[Fact]
Expand Down