Skip to content

DotMemoryDiagnoser implementation #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyAkinshin merged 4 commits into from
Apr 1, 2024
Merged

DotMemoryDiagnoser implementation #2549

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78dfe71
DotMemoryDiagnoser implementation
martinothamar Mar 30, 2024
dfaacb9
Typo fix, less alloc in test
martinothamar Mar 31, 2024
ad3a9e5
attempt to fix reinit logic for tool
martinothamar Mar 31, 2024
999dae7
Simplify implementation
martinothamar Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
attempt to fix reinit logic for tool
  • Loading branch information
@martinothamar
martinothamar committed Mar 31, 2024
commit ad3a9e5785d5a169a4bc529005c988f9d9c9d71e
6 changes: 3 additions & 3 deletions src/BenchmarkDotNet.Diagnostics.dotMemory/DotMemoryDiagnoser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ public void Handle(HostSignal signal, DiagnoserActionParameters parameters)
{
var logger = parameters.Config.GetCompositeLogger();
var job = parameters.BenchmarkCase.Job;
if (tool is null)
bool isInProcess = job.GetToolchain().IsInProcess;
if (tool is null || (isInProcess ? tool is ExternalDotMemoryTool : tool is InProcessDotMemoryTool))
{
bool isInProcess = job.GetToolchain().IsInProcess;
tool ??= isInProcess
tool = isInProcess
? new InProcessDotMemoryTool(logger, nugetUrl, downloadTo: toolsDownloadFolder)
: new ExternalDotMemoryTool(logger, nugetUrl, downloadTo: toolsDownloadFolder);
}
Expand Down