Skip to content

Simplify dotTrace diagnoser, dedupe common code #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinothamar wants to merge 4 commits into from
Closed

Simplify dotTrace diagnoser, dedupe common code #2558

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a6e010
Simplify dotTrace diagnoser by only using JB.SelfApi, dedupe som code…
martinothamar Apr 12, 2024
635321a
Ditch shared classlib, just use a folder
martinothamar Apr 13, 2024
e26d1ba
simplify shared namespace
martinothamar Apr 14, 2024
943a8b2
recursive wildcard include
martinothamar Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
recursive wildcard include
  • Loading branch information
@martinothamar
martinothamar committed Apr 14, 2024
commit 943a8b2bbbb211345082e5e932584c97e5ac9a66
2 changes: 1 addition & 1 deletion ...Brains/BenchmarkDotNet.Diagnostics.dotMemory/BenchmarkDotNet.Diagnostics.dotMemory.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</ItemGroup>

<ItemGroup>
<Compile Include="..\Shared\*.cs" />
<Compile Include="..\Shared\**\*.cs" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...etBrains/BenchmarkDotNet.Diagnostics.dotTrace/BenchmarkDotNet.Diagnostics.dotTrace.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</ItemGroup>

<ItemGroup>
<Compile Include="..\Shared\*.cs" />
<Compile Include="..\Shared\**\*.cs" />
</ItemGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion src/JetBrains/Shared/Progress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace BenchmarkDotNet.JetBrains
{

internal sealed class Progress : IProgress<double>
Copy link
Collaborator

@timcassell timcassell Apr 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was public before. Is it ok to remove it from public API? @AndreyAkinshin

Copy link
Contributor Author

@martinothamar martinothamar Apr 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I forgot to mention that. I figured since it's not used by any configuration or anything it makes sense to not expose it? Users could have referenced it for some reason, but not because of any interaction with BenchmarkDotNet AFAICT.

If we keep it public I probably have to do something about the namespace, so that both packages don't expose the same type in the same namespace, unless that's not a big deal since we don't expect anyone to import BenchmarkDotNet.JetBrains regardless of which package is used?

{
private static readonly TimeSpan ReportInterval = TimeSpan.FromSeconds(0.1);
Expand Down