Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Conversation

@naitp
Copy link
Contributor

@naitp naitp commented Jan 30, 2017

Addresses issue found in #1 (Can't compile the code because of Chinese letters).

@mike-barnett mike-barnett merged commit 6ea2fdd into dotnet:master Jan 31, 2017
@mike-barnett
Copy link
Contributor

Thanks so much! I don't know how that bad byte got in there. However, did you do something that would have committed the file without windows line endings (\r\n)? That appeared to be the case when I pulled the merged file. I just committed a version with the line endings renormalized to Windows line endings.

@dmetzgar
Copy link

That byte comes from encoding. If you use UTF instead of ASCII.

@mike-barnett
Copy link
Contributor

What I meant is that none of the other files in that directory have the byte-encoding byte, so I don't know why that file would have it.

@naitp
Copy link
Contributor Author

naitp commented Jan 31, 2017

Regarding line endings, the only thing I can think of is that the ACE Editor converted them inadvertently when I saved the file (see last comment here: https://github.com/gitlabhq/gitlabhq/issues/3982 from Nov. 2016), but I can't seem to duplicate the issue on any of my repos. Sorry I couldn't be more help with this one. I'll try to duplicate it when I have some more time (when I'm not at work).

@mike-barnett
Copy link
Contributor

No worries! I was just mentioning it because I thought I had put the right magic goo in .gitattributes so that Git would always put in the Windows line endings. I guess line endings and the great tab vs. spaces debate will always be among the great religious battles of the world...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants