This repository was archived by the owner on Mar 19, 2021. It is now read-only.
Basic tests, fixes and better logging for keyfile crashes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jnm2
commented
Sep 15, 2018
| } | ||
|
|
||
| [ComImport, ComConversionLoss, InterfaceType(ComInterfaceType.InterfaceIsIUnknown), Guid("9FD93CCF-3280-4391-B3A9-96E1CDE77C8D")] | ||
| private interface IClrStrongName |
Contributor
Author
There was a problem hiding this comment.
For future readers: this is a bad interface declaration because COM interface calls are made in .NET not by method name but rather method declaration order inside the interface. There are 16 missing method declarations that should have come lexically above StrongNameSignatureGeneration. Therefore the first slot number is used instead of the seventeenth, and so, in spite of its name, the COM call ends up being to GetHashFromAssemblyFile instead of to StrongNameSignatureGeneration .
See the fix: #49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Per email conversation.]
There wasn't a test project, so I added one.
I removed the deprecated StrongName DllImports, replacing GetPublicKey with StrongNameKeyPair.PublicKey and replacing StrongNameSignatureGeneration with ICLRStrongName's method. This fixes the mscorsn loading crashes when running as x64 and is under test in
ConsoleTests.csandKeyTests.cs.I also fixed another crash when the keyfile blob is unreadable. Instead, the exception message is passed to the log with helpful information. This is also under test in
KeyTests.cs.