Skip to content

When generating the GitCommitDate field in the AssemblyInfo for F#, d… #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 1 commit into from
Aug 22, 2025
Merged

When generating the GitCommitDate field in the AssemblyInfo for F#, d… #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
When generating the GitCommitDate field in the AssemblyInfo for F#, d… 
…on't add an explicit 'new'
  • Loading branch information
@Numpsy
Numpsy committed Aug 17, 2025
commit 51bfdf12bc192e39b017be4f13b413d3285f1d7c
2 changes: 1 addition & 1 deletion src/Nerdbank.GitVersioning.Tasks/AssemblyVersionInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ internal override void AddThisAssemblyMember(string name, bool value)

internal override void AddThisAssemblyMember(string name, DateTime value)
{
this.CodeBuilder.AppendLine($" static member internal {name} = new global.System.DateTime({value.Ticks}L, global.System.DateTimeKind.Utc)");
this.CodeBuilder.AppendLine($" static member internal {name} = global.System.DateTime({value.Ticks}L, global.System.DateTimeKind.Utc)");
}

internal override void StartAssemblyAttributes()
Expand Down
2 changes: 1 addition & 1 deletion test/Nerdbank.GitVersioning.Tests/AssemblyInfoTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ type internal ThisAssembly() =
static member internal CustomBool = true
static member internal CustomString1 = ""abc""
static member internal CustomString3 = """"
static member internal CustomTicks = new global.System.DateTime(637509805729817056L, global.System.DateTimeKind.Utc)
static member internal CustomTicks = global.System.DateTime(637509805729817056L, global.System.DateTimeKind.Utc)
static member internal IsPrerelease = false
static member internal IsPublicRelease = false
static member internal RootNamespace = """"
Expand Down
Loading